Clean up and organize in separate packages (!6) · Merge requests · adi-ia / cbs-techstore-client-php · GitLab

Improve security with one click by enabling Secret Push Protection for your projects: https://docs.gitlab.com/ee/user/application_security/secret_detection/secret_push_protection/#enable-secret-push-protection-in-a-project

Paul Erickson requested to merge paul.erickson/cbs-techstore-client-php:master into master Apr 07, 2016

I found this project very confusing, so as I read through it, I made changes that I think make it easier to understand.

Exotic looking generated classes!

I moved these to wsdl-generated-classes so that they are not mixed in with our code (as it is, classGenerator.php would delete our code too, right?)
When I ran classGenerator.php, the class names ended in "Custom"; is this normal?

Interface, facade, and implementation are all in the same package - hard to tell what's what

Put the service interface and domain object in an api package, and the client, in a client package.

Unit test for a mock class

Deleted and made canary tests for real classes (currently no logic to test anyway)

Renamed integration test as "IT" to match naming convention in phpunit config
Removed unused mockery dependency

Please review: @ahoffmann @weizhong-wang @alundholm @SDUNAGAN