Skip to content

Refactor `MagentoOrder` and redefine constants

Andy Summers requested to merge andrew-summers/cbs-techstore-client-php:magento-order-refactor into master

This PR refactors the MagentoOrder class into three new classes. MagentoOrder was sort of a junk drawer for CBS related constants, and the three new classes more accurately reflect what the constants are for. It also changes several of the constant names and/or values, to either more accurately reflect their use (e.g. PERSONAL_IDENTIFIER_TYPE -> PVI, as it will now be used to identify departmental customers) or change them completely to what CBS now expects (e.g. INSTITUTIONAL -> DEPARTMENTAL).

Please review: @ahoffmann @weizhong-wang @lloyd-carter @KJOYNER

Merge request reports