Skip to content

Get all tests passing

Andy Summers requested to merge andrew-summers/scout:passing-tests into master

This PR gets all tests for Scout passing! 🎊 🎉 💯

Notes

  1. One change here switches some assertEqual() calls to assertCountEqual(). assertCountEqual is a misleading name, because not only does it assert that the two counts are equal, but it also asserts that each item is equal. For the purposes of this PR, that means that assertCountEqual(["Vietnamese", "Indian"], ["Indian", "Vietnamese"]) == True), but importantly, assertEqual(["Vietnamese", "Indian"], ["Indian", "Vietnamese"]) == False). We don't care about the ordering of the lists necessarily, just that the correct items (and count) is returned.
  2. The second test was failing on 302 != 301, which just meant that the Django RedirectView needed the permanent=True param.

Please review, and rejoice in having FULL TESTS PASSING for at least one of these apps: @NUWAN.KUMARASIRI @TREFILEK @bjsousa

Merge request reports